[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[altq 727] Re: small ALTQ bug




Lars Eggert wrote:
> I think I've come across a small bug in ALTQ. It doesn't seem to be
> triggered during normal operation, I found it when extending ALTQ to handle
> inbound processing. (Which is coming along nicely, by the way.)
> 
> The problem is that _addq() and _getq() do not clear the m_nextpkt pointer.
> This causes all kinds of panics when such mbufs end up in other queues
> which also chain mbufs using that pointer (e.g. socket buffers). Again,
> this isn't a problem normally, since ALTQ isn't used for inbound
> processing.

Well, I won't call it a bug since it isn't expected to be used in such
a way :)  

> The two patches below fix the problem, maybe you'd like to apply them to
> the CVS tree anyway:

I will.  Thanks.

-Kenjiro